feat: Integrate Bitget for Rate Fetching & Median Calculation Across Multiple Providers #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundayonah
requested review from
chibie,
5ran6 and
OnahProsperity
as code owners
chibie
requested changes
Feb 20, 2025
Comment on lines
+147
to
+148
| Build().POST("/api/v2/p2p/adv/search"). | ||
| Retry().Set(3, 5*time.Second). |
There was a problem hiding this comment.
which documentation are you using for Bitget?
There was a problem hiding this comment.
I thought I had already mentioned this earlier, but the Bitget endpoint you provided in the user story https://www.bitget.com/api-doc/common/p2p/Get-P2P-Order-List isn’t working
I’m getting the following error message:
This site can’t be reached
www.bitget.com’s DNS address could not be found. Diagnosing the problem.
DNS_PROBE_POSSIBLE
There was a problem hiding this comment.
Comment on lines
+144
to
+146
| res, err := fastshot.NewClient(BitgetAPIURL). | ||
| Config().SetTimeout(30*time.Second). | ||
| Header().Add("Content-Type", "application/json"). |
There was a problem hiding this comment.
aren't some extra auth headers required?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates Bitget as a source for fetching rates for all supported currencies (e.g., NGN, KES, GHS). It enhances the rate calculation system by retrieving data from multiple providers (Quidax, Binance, and Bitget) and computing the median rate for improved accuracy and reliability.
References
Closes #423
Bitget API Documentation
Testing
Checklist
mainBy submitting a PR, I agree to Paycrest's Contributor Code of Conduct and Contribution Guide.